From e725502afae8da3e614b90429703e73f713fd58c Mon Sep 17 00:00:00 2001 From: John Thacker Date: Fri, 26 Aug 2022 00:17:40 -0400 Subject: [PATCH] tcp: Fix a comparison that should be strict in OOO processing We don't want to add a zero length segment to the reassembly here. Related to #17406 --- epan/dissectors/packet-tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/epan/dissectors/packet-tcp.c b/epan/dissectors/packet-tcp.c index 53a01dce4c..8b95c6695e 100644 --- a/epan/dissectors/packet-tcp.c +++ b/epan/dissectors/packet-tcp.c @@ -3674,7 +3674,7 @@ split_msp(packet_info *pinfo, struct tcp_multisegment_pdu *msp, struct tcp_analy guint32 frag_offset = fd_i->offset; guint32 frag_len = fd_i->len; /* Check for some unusual out of order overlapping segment situations. */ - if (split_offset <= frag_offset + frag_len) { + if (split_offset < frag_offset + frag_len) { if (fd_i->offset < split_offset) { frag_offset = split_offset; frag_len -= (split_offset - fd_i->offset);