From e6eb4815cd426d8ea30d0ef3225bc27f39dab776 Mon Sep 17 00:00:00 2001 From: Jakub Zawadzki Date: Mon, 22 Jan 2018 18:28:16 +0100 Subject: [PATCH] gtk: Fix memory error/double free. pathname is freed by caller of firewall_save_as_ok_cb(). Make pathname const. Found by clang scan. Change-Id: I3a0ab85494a9194edb825bae33eca979c7f8faf3 Reviewed-on: https://code.wireshark.org/review/25417 Petri-Dish: Jakub Zawadzki Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki --- ui/gtk/firewall_dlg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui/gtk/firewall_dlg.c b/ui/gtk/firewall_dlg.c index f671465c17..ec422e9e53 100644 --- a/ui/gtk/firewall_dlg.c +++ b/ui/gtk/firewall_dlg.c @@ -462,7 +462,7 @@ firewall_copy_cmd_cb(GtkWidget *w _U_, gpointer data) } static gboolean -firewall_save_as_ok_cb(char *to_name, rule_info_t *rule_info) +firewall_save_as_ok_cb(const char *to_name, rule_info_t *rule_info) { FILE *fh; gchar *rule; @@ -473,7 +473,6 @@ firewall_save_as_ok_cb(char *to_name, rule_info_t *rule_info) fh = ws_fopen(to_name, "w"); if (fh == NULL) { open_failure_alert_box(to_name, errno, TRUE); - g_free(to_name); return FALSE; }