From e60cb857de35011389a807ea023ba2cdbd33c97e Mon Sep 17 00:00:00 2001 From: Thomas Wiens Date: Mon, 3 Dec 2018 20:29:35 +0100 Subject: [PATCH] s7comm: fix using wrong offset variable Change-Id: I9cfd8394e6cbb3f627f7f312fa19fc5baa62f6fc Reviewed-on: https://code.wireshark.org/review/30905 Reviewed-by: Anders Broman Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin --- epan/dissectors/packet-s7comm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/epan/dissectors/packet-s7comm.c b/epan/dissectors/packet-s7comm.c index a15c27037f..2908e37717 100644 --- a/epan/dissectors/packet-s7comm.c +++ b/epan/dissectors/packet-s7comm.c @@ -4798,7 +4798,7 @@ s7comm_decode_ud(tvbuff_t *tvb, proto_tree_add_item(param_tree, hf_s7comm_userdata_param_len, tvb, offset_temp, 1, ENC_BIG_ENDIAN); offset_temp += 1; /* 1 byte indicating request/response again, but useful in Push telegrams*/ - proto_tree_add_item_ret_uint(param_tree, hf_s7comm_userdata_param_reqres2, tvb, offset, 1, ENC_BIG_ENDIAN, &reqres2); + proto_tree_add_item_ret_uint(param_tree, hf_s7comm_userdata_param_reqres2, tvb, offset_temp, 1, ENC_BIG_ENDIAN, &reqres2); offset_temp += 1; /* High nibble (following/request/response) */ type = (tvb_get_guint8(tvb, offset_temp) & 0xf0) >> 4;