From e3d0bf0bb2aea5e6f18cce32ad0e75e14169c413 Mon Sep 17 00:00:00 2001 From: Dario Lombardo Date: Thu, 3 Aug 2017 13:39:26 +0200 Subject: [PATCH] extcap: skip custom log if filename is space. Change-Id: I98b890316af05d9c5359dc38a30d07ac55f262fe Reviewed-on: https://code.wireshark.org/review/22932 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo --- extcap/extcap-base.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/extcap/extcap-base.c b/extcap/extcap-base.c index 0e854d7c0c..1e1a49c7e0 100644 --- a/extcap/extcap-base.c +++ b/extcap/extcap-base.c @@ -357,6 +357,8 @@ void extcap_help_add_header(extcap_parameters * extcap, char * help_header) void extcap_init_custom_log(const char* filename) { + if (!filename || strlen(filename) == 0) + return; custom_log = fopen(filename, "w"); if (!custom_log) g_error("Can't open custom log file: %s (%s)", filename, strerror(errno)); @@ -365,10 +367,10 @@ void extcap_init_custom_log(const char* filename) void extcap_config_debug(unsigned* count) { printf("arg {number=%u}{call=--debug}{display=Run in debug mode}" - "{type=boolean}{default=false}{tooltip=Print debug messages}\n", + "{type=boolean}{default=false}{tooltip=Print debug messages}{required=false}\n", (*count)++); printf("arg {number=%u}{call=--debug-file}{display=Use a file for debug}" - "{type=string}{tooltip=Set a file where the debug messages are written}\n", + "{type=string}{tooltip=Set a file where the debug messages are written}{required=false}\n", (*count)++); }