From e3477bd13635a637d1337093457dbad499bd5538 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Fri, 17 Oct 2014 16:57:28 -0700 Subject: [PATCH] Get rid of some no-longer-necessary casts. g_ascii_isXXX() can be handed a char value safely; they won't try to use it as an index into a table before checking it. Change-Id: Icf80163fb5f9dccd0b97917e318b1db0bf3e0cf8 Reviewed-on: https://code.wireshark.org/review/4801 Reviewed-by: Guy Harris --- capture_opts.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/capture_opts.c b/capture_opts.c index 9e75aa4d0b..b41f83468e 100644 --- a/capture_opts.c +++ b/capture_opts.c @@ -258,7 +258,7 @@ set_autostop_criterion(capture_options *capture_opts, const char *autostoparg) * as we allow it in the preferences file, we might as well * allow it here). */ - while (g_ascii_isspace((guchar)*p)) + while (g_ascii_isspace(*p)) p++; if (*p == '\0') { /* @@ -309,7 +309,7 @@ get_ring_arguments(capture_options *capture_opts, const char *arg) * as we allow it in the preferences file, we might as well * allow it here). */ - while (g_ascii_isspace((guchar)*p)) + while (g_ascii_isspace(*p)) p++; if (*p == '\0') { /* @@ -355,7 +355,7 @@ get_sampling_arguments(capture_options *capture_opts, const char *arg) p = colonp; *p++ = '\0'; - while (g_ascii_isspace((guchar)*p)) + while (g_ascii_isspace(*p)) p++; if (*p == '\0') { *colonp = ':'; @@ -413,7 +413,7 @@ get_auth_arguments(capture_options *capture_opts, const char *arg) p = colonp; *p++ = '\0'; - while (g_ascii_isspace((guchar)*p)) + while (g_ascii_isspace(*p)) p++; if (capture_opts->ifaces->len > 0) {