osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Change dissect_deferred_pointer() 

from being Ordo(n^2) into being Ordo(n)

Makes it slightly faster when n (the number of pointers) is >10.000

The mother of all dcerpc packets (containing one array of >10.000 pointers)
was a bit slow.

It is still slow but at least completes in out lifetime.

svn path=/trunk/; revision=8647
This commit is contained in:
Ronnie Sahlberg 2003-10-08 12:29:52 +00:00
parent fe0ee6ad14
commit e140f2858c
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packet-dcerpc.c
View File

@ -3,7 +3,7 @@
* Copyright 2001, Todd Sabin <tas@webspan.net>
* Copyright 2003, Tim Potter <tpot@samba.org>
*
* $Id: packet-dcerpc.c,v 1.142 2003/09/26 06:30:13 tpot Exp $
* $Id: packet-dcerpc.c,v 1.143 2003/10/08 12:29:52 sahlberg Exp $
*
* Ethereal - Network traffic analyzer
* By Gerald Combs <gerald@ethereal.com>
@ -1314,19 +1314,22 @@ dissect_deferred_pointers(packet_info *pinfo, tvbuff_t *tvb, int offset, char *d
int found_new_pointer;
dcerpc_info *di;
int old_offset;
int next_pointer;
next_pointer=0;
di=pinfo->private_data;
do{
int i, len;
found_new_pointer=0;
len=g_slist_length(ndr_pointer_list);
for(i=0;i<len;i++){
for(i=next_pointer;i<len;i++){
ndr_pointer_data_t *tnpd;
tnpd=g_slist_nth_data(ndr_pointer_list, i);
if(tnpd->fnct){
dcerpc_dissect_fnct_t *fnct;
next_pointer=i+1;
found_new_pointer=1;
fnct=tnpd->fnct;
tnpd->fnct=NULL;