From dde65b96cde8a4dd94ce15cb451a2e7fd85a9014 Mon Sep 17 00:00:00 2001 From: Chuck Craft Date: Sun, 14 Feb 2021 16:02:11 -0600 Subject: [PATCH] ip: ip_ttl _ws.expert fields not set if no tree See 'if (tree) ...' comment Closes #17228 --- epan/dissectors/packet-ip.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/epan/dissectors/packet-ip.c b/epan/dissectors/packet-ip.c index 13de6a6c88..6d54db0c84 100644 --- a/epan/dissectors/packet-ip.c +++ b/epan/dissectors/packet-ip.c @@ -2023,11 +2023,7 @@ dissect_ip_v4(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree, void* tf = proto_tree_add_uint(ip_tree, hf_ip_frag_offset, tvb, offset + 6, 2, (iph->ip_off & IP_OFFSET)*8); iph->ip_ttl = tvb_get_guint8(tvb, offset + 8); - if (tree) { - ttl_item = proto_tree_add_item(ip_tree, hf_ip_ttl, tvb, offset + 8, 1, ENC_BIG_ENDIAN); - } else { - ttl_item = NULL; - } + ttl_item = proto_tree_add_item(ip_tree, hf_ip_ttl, tvb, offset + 8, 1, ENC_BIG_ENDIAN); iph->ip_proto = tvb_get_guint8(tvb, offset + 9); if (tree) {