From ddb187fe0c8844ca278a7b6b5a90da3a6f0aa36a Mon Sep 17 00:00:00 2001 From: Matthias Isele Date: Wed, 4 Jan 2023 08:48:46 +0000 Subject: [PATCH] fixes #18777 wrong decoding order in parseDiagnosticInfo --- plugins/epan/opcua/opcua_simpletypes.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/epan/opcua/opcua_simpletypes.c b/plugins/epan/opcua/opcua_simpletypes.c index dc1bb0457b..59397889ca 100644 --- a/plugins/epan/opcua/opcua_simpletypes.c +++ b/plugins/epan/opcua/opcua_simpletypes.c @@ -835,14 +835,14 @@ void parseDiagnosticInfo(proto_tree *tree, tvbuff_t *tvb, packet_info *pinfo, gi { parseInt32(subtree, tvb, pinfo, &iOffset, hf_opcua_diag_namespace); } - if (EncodingMask & DIAGNOSTICINFO_ENCODINGMASK_LOCALIZEDTEXT_FLAG) - { - parseInt32(subtree, tvb, pinfo, &iOffset, hf_opcua_diag_localizedtext); - } if (EncodingMask & DIAGNOSTICINFO_ENCODINGMASK_LOCALE_FLAG) { parseInt32(subtree, tvb, pinfo, &iOffset, hf_opcua_diag_locale); } + if (EncodingMask & DIAGNOSTICINFO_ENCODINGMASK_LOCALIZEDTEXT_FLAG) + { + parseInt32(subtree, tvb, pinfo, &iOffset, hf_opcua_diag_localizedtext); + } if (EncodingMask & DIAGNOSTICINFO_ENCODINGMASK_ADDITIONALINFO_FLAG) { parseString(subtree, tvb, pinfo, &iOffset, hf_opcua_diag_additionalinfo);