From d8cdb550445a1bc86626bd9d45da1ce958d1592b Mon Sep 17 00:00:00 2001 From: Gerald Combs Date: Fri, 2 Dec 2016 11:36:45 -0800 Subject: [PATCH] Autotools: Disable Qt4 on macOS. Add a check for macOS+Qt4 to configure.ac in order to roughly match the CMake behavior in ge858829. Change-Id: I37de95d5db515d28dd88f13d818531bf6e94d07e Reviewed-on: https://code.wireshark.org/review/19036 Reviewed-by: Gerald Combs Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu --- configure.ac | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 1ba2415153..d39c3746d6 100644 --- a/configure.ac +++ b/configure.ac @@ -1293,18 +1293,19 @@ if test "x$enable_wireshark" = "xyes"; then AC_SUBST(LRELEASE) # - # On Darwin, find where the Qt frameworks are - # located, and add that to the rpath, just in - # case this is Qt 5.5 or later and the frameworks - # have an install name that begins with @rpath - # and aren't installed in a frameworks directory - # that's searched by default. + # On Darwin, make sure we're using Qt5 or later. + # If so, find where the Qt frameworks are located + # and add that to the rpath, just in case this is + # Qt 5.5 or later and the frameworks have an + # install name that begins with @rpath and aren't + # installed in a frameworks directory that's + # searched by default. # case "$host_os" in darwin*) if test $qt_version -le 4 then - Qt_LDFLAGS="-Wl,-rpath,"`$PKG_CONFIG --libs QtCore | sed -e 's/-F//' -e 's/ -framework.*//'` + AC_MSG_ERROR([macOS builds should use Qt5]) else Qt_LDFLAGS="-Wl,-rpath,"`$PKG_CONFIG --libs Qt${qt_version}Core | sed -e 's/-F//' -e 's/ -framework.*//'` fi