osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Remind people not to use "g_ntoh[ls]()" or "g_hton[ls]()" to convert 

big-endian to little-endian - that doesn't work on big-endian machines.

svn path=/trunk/; revision=13874
This commit is contained in:
Guy Harris 2005-03-23 02:39:21 +00:00
parent 596a4f865b
commit d4d1206ad5
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
doc/README.developer
View File

@ -149,6 +149,14 @@ those are declared by <glib.h>, and you'll need to include that anyway,
as Ethereal header files that all dissectors must include use stuff from as Ethereal header files that all dissectors must include use stuff from
<glib.h>. <glib.h>.
Don't fetch a little-endian value using "tvb_get_ntohs() or
"tvb_get_ntohl()" and then using "g_ntohs()", "g_htons()", "g_ntohl()",
or "g_htonl()" on the resulting value - the g_ routines in question
convert between network byte order (big-endian) and *host* byte order,
not *little-endian* byte order; not all machines on which Ethereal runs
are little-endian, even though PC's are. Fetch those values using
"tvb_get_letohs()" and "tvb_get_letohl()".
Don't put a comma after the last element of an enum - some compilers may Don't put a comma after the last element of an enum - some compilers may
either warn about it (producing extra noise) or refuse to accept it. either warn about it (producing extra noise) or refuse to accept it.