osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

GSM Um: fix V695 warning found by PVS-Studio 

Range intersections are possible within conditional expressions. Example: if (A > 0 && A < 5) { ... } else if (A > 3 && A < 9) { ... }.
E-GSM and R-GSM EARFCNs are overlapping, as seen in 3GPP TS 05.05.

Change-Id: I5b9be53ba85109a674b05ae16cd729557cec6318
Reviewed-on: https://code.wireshark.org/review/8817
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
This commit is contained in:
Pascal Quantin 2015-06-07 17:47:25 +02:00
parent 7fc302e7a7
commit d48fe0d2e4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-gsm_um.c
View File

@ -73,7 +73,7 @@ decode_arfcn(guint16 arfcn, const char **band, guint *uplink, guint *downlink)
*uplink = 890000 + 200 * (arfcn - 1024);
*downlink = *uplink + 45000;
}
else if( arfcn >= 955 && arfcn <= 1023 ) {
else if( arfcn >= 955 && arfcn <= 974 ) {
*band = "R-GSM 900";
*uplink = 890000 + 200 * (arfcn - 1024);
*downlink = *uplink + 45000;