From cb8fc2874c6353ef8f036c04bb79d37e6fc8b657 Mon Sep 17 00:00:00 2001
From: Roland Knall <rknall@gmail.com>
Date: Mon, 25 Jul 2022 11:42:25 +0200
Subject: [PATCH] macos: Remove no longer needed function

Fixes #18221
---
 ui/macosx/sparkle_bridge.h |  2 --
 ui/macosx/sparkle_bridge.m | 18 ------------------
 ui/software_update.c       |  1 -
 3 files changed, 21 deletions(-)

diff --git a/ui/macosx/sparkle_bridge.h b/ui/macosx/sparkle_bridge.h
index 844e54d6ed..8ba7e4a8af 100644
--- a/ui/macosx/sparkle_bridge.h
+++ b/ui/macosx/sparkle_bridge.h
@@ -22,6 +22,4 @@ void sparkle_software_update_init(const char *url, bool enabled, int interval);
 
 void sparkle_software_update_check(void);
 
-void sparkle_software_update_cleanup(void);
-
 #endif // SPARKLE_BRIDGE_H
diff --git a/ui/macosx/sparkle_bridge.m b/ui/macosx/sparkle_bridge.m
index a596fcb0bc..7a6509ad88 100644
--- a/ui/macosx/sparkle_bridge.m
+++ b/ui/macosx/sparkle_bridge.m
@@ -53,21 +53,3 @@ void sparkle_software_update_check(void)
 {
     [[SparkleBridge sharedStandardUpdaterController] checkForUpdates: [[NSApplication sharedApplication] delegate]];
 }
-
-// Sparkle requires NSApplicationWillTerminateNotification in order to
-// properly update in the background.
-//
-// https://github.com/sparkle-project/Sparkle/issues/232
-// https://github.com/sparkle-project/Sparkle/issues/892
-// https://github.com/sparkle-project/Sparkle/issues/839
-//
-// This depends on the Sparkle framework being able to run Autoupdate.app.
-// If that's not reliable we might want to disable SUAllowsAutomaticUpdates
-// above.
-
-void sparkle_software_update_cleanup()
-{
-    [[NSNotificationCenter defaultCenter]
-            postNotificationName:@"NSApplicationWillTerminateNotification"
-        object:nil];
-}
diff --git a/ui/software_update.c b/ui/software_update.c
index 2b6c97c8f7..8d30baf125 100644
--- a/ui/software_update.c
+++ b/ui/software_update.c
@@ -157,7 +157,6 @@ software_update_check(void) {
 /** Clean up software update checking.
  */
 void software_update_cleanup(void) {
-    sparkle_software_update_cleanup();
 }
 
 const char *software_update_info(void) {