osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

tests: Remove tests for non-existent functionality 

Remove tests that are unconditionally skipped because the
feature does not exist or is non-functional.

Related to #17772.
This commit is contained in:
João Valverde 2021-12-07 23:39:30 +00:00 committed by Wireshark GitLab Utility
parent 91bf99405a
commit c29d3b9fa0
1 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/suite_dfilter/group_tvb.py
View File

@ -11,19 +11,6 @@ from suite_dfilter.dfiltertest import *
class case_tvb(unittest.TestCase):
trace_file = "http.pcap"
@unittest.skip("Protocol equality doesn't work yet in Wireshark")
def test_eq_1(self, checkDFilterCount):
# Protocols cannot work in an '==' comparison yet. The protocol
# fvalue length runs to the end of the TVBuff. This needs to be fixed.
dfilter = "eth == 00:e0:81:00:b0:28:00:09:6b:88:f5:c9:08:00"
checkDFilterCount(dfilter, 1)
@unittest.skip("Protocol equality doesn't work yet in Wireshark")
def test_eq_2(self, checkDFilterCount):
# This is a more stringent test than 'eth' above because TCP has variable length.
dfilter = "tcp == 0c:c3:00:50:a8:00:76:87:7d:e0:14:02:50:18:fa:f0:ad:62:00:00"
checkDFilterCount(dfilter, 1)
def test_slice_1(self, checkDFilterCount):
dfilter = "ip[0:2] == 45:00"
checkDFilterCount(dfilter, 1)
@ -36,13 +23,6 @@ class case_tvb(unittest.TestCase):
dfilter = "ip[2:2] == 00:c1"
checkDFilterCount(dfilter, 1)
@unittest.skip("Negative offsets don't work yet in Wireshark")
def test_slice_4(self, checkDFilterCount):
# Fixing protocol equality would also fix this. Wireshark's understanding
# of protocol length is wrong so the "offset from the end" is also wrong.
dfilter = "ip[-1] == 0x5e"
checkDFilterCount(dfilter, 1)
def test_contains_1(self, checkDFilterCount):
dfilter = "eth contains 6b"
checkDFilterCount(dfilter, 1)