Use "must" instead of "should" to avoid ambiguity.

As I said in

    https://ask.wireshark.org/question/10361/how-to-properly-use-heuristic-dissector-for-tcp/?answer=10363#post-id-10363

  "Should" has multiple meanings; there's "Used to indicate obligation,
  duty, or correctness, typically when criticizing someone's actions.", as
  in "I think we should trust our people more", and there's "Used to
  indicate what is probable.", as in "the bus should arrive in a few
  minutes". You're reading it in the latter sense; it was intended in the
  former sense.

  That sentence should probably be changed to "Wireshark must be then set
  up..." to avoid the ambiguity.

Make it so (over half a year later, sigh), and change another case where
"should" is meant in the first sense while we're at it.

Change-Id: I90198d1616619c75802deeeb703ceee0c8bac1bf
Reviewed-on: https://code.wireshark.org/review/36155
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This commit is contained in:
Guy Harris 2020-02-22 20:35:43 -08:00
parent e4138a3b98
commit c268e9b0d5
1 changed files with 2 additions and 2 deletions

View File

@ -60,7 +60,7 @@ SCTP, TCP, TIPC and UDP dissectors all provide this capability via their
option enabled by default.
Once a packet for a particular "connection" has been identified as belonging
to a particular protocol, Wireshark should then be set up to always directly
to a particular protocol, Wireshark must then be set up to always directly
call the dissector for that protocol. This removes the overhead of having
to identify each packet of the connection heuristically.
@ -94,7 +94,7 @@ that it's not good enough to distinguish between two given protocols.
Note: The heuristic code in a dissector *must not* cause an exception
(before returning FALSE) as this will prevent following
heuristic dissector handoffs. In practice, this normally means
that a test should be done to verify that the required data is
that a test must be done to verify that the required data is
available in the tvb before fetching from the tvb. (See the
example below).