osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

dumpcap: Improve the secondary error for promiscuous mode failure. 

On Windows, some devices don't let promiscuous mode be enabled, and
return an error rather than silently ignoring the request to use
promiscuous mode (as UN*X devices tend to do).  Check for the error
message from that error, and suggest that the user turn off promiscuous
mode on that device.
This commit is contained in:
Guy Harris 2020-12-27 12:55:31 -08:00
parent c15025f684
commit c15a37db51
1 changed files with 30 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
dumpcap.c
View File

@ -556,7 +556,8 @@ relinquish_all_capabilities(void)
#endif
static const char *
get_pcap_failure_secondary_error_message(cap_device_open_err open_err)
get_pcap_failure_secondary_error_message(cap_device_open_err open_err,
const char *open_err_str)
{
#ifdef _WIN32
/*
@ -580,13 +581,33 @@ get_pcap_failure_secondary_error_message(cap_device_open_err open_err)
*/
if (open_err == CAP_DEVICE_OPEN_ERR_GENERIC) {
/*
* We don't know what kind of error it is, so throw all the
* suggestions at the user.
* We don't know what kind of error it is. See if there's a hint
* in the error string; if not, throw all generic suggestions at
* the user.
*/
return
"Please check to make sure you have sufficient permissions, and that you have "
"the proper interface or pipe specified."
PLATFORM_PERMISSIONS_SUGGESTION;
static const char promisc_failed[] =
"failed to set hardware filter to promiscuous mode";
/*
* Does the error string begin with the error produced by WinPcap
* and Npcap if attempting to set promiscuous mode fails?
* (Note that this string could have a specific error message
* from an NDIS error after the initial part, so we do a prefix
* check rather than an exact match check.)
*/
if (strncmp(open_err_str, promisc_failed, sizeof promisc_failed - 1) == 0) {
/*
* Yes. Suggest that the user turn off promiscuous mode on that
* device.
*/
return
"Please turn off promiscuous mode for this device";
} else {
return
"Please check to make sure you have sufficient permissions, and that you have "
"the proper interface or pipe specified."
PLATFORM_PERMISSIONS_SUGGESTION;
}
} else if (open_err == CAP_DEVICE_OPEN_ERR_PERMISSIONS) {
/*
* This is a permissions error, so no need to specify any other
@ -617,7 +638,7 @@ get_capture_device_open_failure_messages(cap_device_open_err open_err,
"The capture session could not be initiated on interface '%s' (%s).",
iface, open_err_str);
g_snprintf(secondary_errmsg, (gulong) secondary_errmsg_len, "%s",
get_pcap_failure_secondary_error_message(open_err));
get_pcap_failure_secondary_error_message(open_err, open_err_str));
}
static gboolean
@ -5318,7 +5339,7 @@ main(int argc, char *argv[])
if (caps == NULL) {
cmdarg_err("The capabilities of the capture device \"%s\" could not be obtained (%s).\n"
"%s", interface_opts->name, err_str,
get_pcap_failure_secondary_error_message(err));
get_pcap_failure_secondary_error_message(err, err_str));
g_free(err_str);
exit_main(2);
}