osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

memory leak: Qt code doesn't pass 'parent' argument to some Qt class constructors 

found with valgrind

Change-Id: I2d73bd50a6f0e13b1817c8a518189c0e56558f72
Reviewed-on: https://code.wireshark.org/review/21227
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
This commit is contained in:
Max Dmitrichenko 2017-04-19 17:11:43 -04:00 committed by Peter Wu
parent 3e755bb0c1
commit ba3fbc5adb
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/qt/capture_filter_edit.cpp
View File

@ -131,7 +131,7 @@ CaptureFilterEdit::CaptureFilterEdit(QWidget *parent, bool plain) :
if (!plain_) {
bookmark_button_ = new StockIconToolButton(this, "x-capture-filter-bookmark");
bookmark_button_->setCursor(Qt::ArrowCursor);
bookmark_button_->setMenu(new QMenu());
bookmark_button_->setMenu(new QMenu(bookmark_button_));
bookmark_button_->setPopupMode(QToolButton::InstantPopup);
bookmark_button_->setToolTip(tr("Manage saved bookmarks."));
bookmark_button_->setIconSize(QSize(14, 14));

2
ui/qt/interface_frame.cpp
View File

@ -113,7 +113,7 @@ InterfaceFrame::~InterfaceFrame()
QMenu * InterfaceFrame::getSelectionMenu()
{
QMenu * contextMenu = new QMenu();
QMenu * contextMenu = new QMenu(this);
QList<int> typesDisplayed = proxyModel->typesDisplayed();
QMap<int, QString>::const_iterator it = ifTypeDescription.constBegin();