osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Add sanity check to ensure integer types don't get set to BASE_NONE. 

This is checked by Wireshark, but the script should catch it earlier in case Wireshark/TShark isn't run after the script is executed (a mistake I've made several times).

Change-Id: I1d113871b10fcae5a6d3e9036cc80d7b1ec1ae57
Reviewed-on: https://code.wireshark.org/review/6245
Reviewed-by: Michael Mann <mmann78@netscape.net>
This commit is contained in:
Michael Mann 2015-01-02 12:34:21 -05:00
parent e7d0cdc061
commit b90f7846f4
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tools/convert_proto_tree_add_text.pl
View File

@ -299,6 +299,21 @@ sub verify_line {
$errors++;
}
}
if (($proto_tree_item[9] eq "FT_UINT8") ||
($proto_tree_item[9] eq "FT_UINT16") ||
($proto_tree_item[9] eq "FT_UINT24") ||
($proto_tree_item[9] eq "FT_UINT32") ||
($proto_tree_item[9] eq "FT_UINT64") ||
($proto_tree_item[9] eq "FT_INT8") ||
($proto_tree_item[9] eq "FT_INT16") ||
($proto_tree_item[9] eq "FT_INT24") ||
($proto_tree_item[9] eq "FT_INT32") ||
($proto_tree_item[9] eq "FT_INT64")) {
if ($proto_tree_item[11] eq "BASE_NONE") {
print "$line_number: Interger type should not be BASE_NONE!\n";
$errors++;
}
}
} elsif ($proto_tree_item[1] eq "2") {
if (!($proto_tree_item[3] =~ /^ei_/)) {