osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

proto: Fix validity test for proto names 

We want at least one letter.  Because protocol names can contain
dots and hyphens testing for !isdigit is not enough to make it
dissimilar to decimal numeric expressions.
This commit is contained in:
João Valverde 2023-01-03 11:34:43 +00:00
parent 396f20606e
commit b893616048
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
epan/proto.c
View File

@ -7466,16 +7466,16 @@ check_protocol_filter_name_or_fail(const char *filter_name)
filter_name, filter_name[0], filter_name[1]);
}
/* Check that it doesn't have all decimal digits. */
bool all_digits = true;
/* Check that it contains at least one letter. */
bool have_letter = false;
for (const char *s = filter_name; *s != '\0'; s++) {
if (!g_ascii_isdigit(*s)) {
all_digits = false;
if (g_ascii_isalpha(*s)) {
have_letter = true;
break;
}
}
if (all_digits) {
REPORT_DISSECTOR_BUG("Protocol filter name \"%s\" cannot be composed of all decimal digits.",
if (!have_letter) {
REPORT_DISSECTOR_BUG("Protocol filter name \"%s\" must contain at least one letter a-z.",
filter_name);
}