osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Fix a comment. 

We already *have* an exported dissector that always dissects PPP without
HDLC-like framing; the question is whether we should have one that
always dissects PPP with HDLC-like framing (with a check for the
HDLC-like framing, in case, for example, it was negotiated away), but
doesn't check for Cisco HDLC.

Change-Id: I3b3319dd29c7516220b82df626bc6ac520ea0dd9
Reviewed-on: https://code.wireshark.org/review/26622
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This commit is contained in:
Guy Harris 2018-03-23 20:33:18 -07:00
parent 0f34a866bb
commit b4b374937f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
epan/dissectors/packet-ppp.c
View File

@ -5856,8 +5856,9 @@ dissect_ppp_hdlc(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data
}
/*
* XXX - should we have an exported dissector that always dissects PPP,
* for use when we know the packets are PPP, not CHDLC?
* XXX - should we have an exported dissector that always dissects
* PPP-in-HDLC-like-framing, without checking for Cisco HDLC, for
* use when we know the packets are PPP, not Cisco HDLC?
*/
col_set_str(pinfo->cinfo, COL_PROTOCOL, "PPP");
switch (pinfo->p2p_dir) {