osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

aeron: the Error String in an Error Header is not null-terminated. 

The Aeron specification says nothing about it being null-terminated, and
in at least some captures, it's not null terminated.

Make it an FT_STRING, rather than an FT_STRINGZ.

Clean up a comment so that more of the URL is visible in a narrower
window.
This commit is contained in:
Guy Harris 2020-09-10 01:39:53 -07:00 committed by AndersBroman
parent 1b5be9bcba
commit b446e36471
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
epan/dissectors/packet-aeron.c
View File

@ -19,7 +19,11 @@
#include <epan/to_str.h>
#include <wsutil/pint.h>
/* The Aeron protocol is defined at https://github.com/real-logic/Aeron/wiki/Protocol-Specification */
/*
* The Aeron protocol is defined at
*
* https://github.com/real-logic/aeron/wiki/Transport-Protocol-Specification
*/
void proto_register_aeron(void);
void proto_reg_handoff_aeron(void);
@ -3202,7 +3206,7 @@ void proto_register_aeron(void)
{ &hf_aeron_err_off_hdr,
{ "Offending Header", "aeron.err.off_hdr", FT_BYTES, BASE_NONE, NULL, 0x0, NULL, HFILL } },
{ &hf_aeron_err_string,
{ "Error String", "aeron.err.string", FT_STRINGZ, BASE_NONE, NULL, 0x0, NULL, HFILL } },
{ "Error String", "aeron.err.string", FT_STRING, BASE_NONE, NULL, 0x0, NULL, HFILL } },
{ &hf_aeron_heartbeat,
{ "Heart Frame", "aeron.heartbeat", FT_NONE, BASE_NONE, NULL, 0x0, NULL, HFILL } },
{ &hf_aeron_heartbeat_frame_length,