osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

TFTP: Minor tweaks to tftp.destination_file field. 

Two trivial cleanups of the definition of the tftp.destination_file field:
There is probably no need to shout DESTINATION in capital letters, and change
"source" to "destination" in the field's blurb.

Testing Done: Built on macOS 10.12.6.  Examined the capture attached to
   bug 10305 (tftpConversationError.pcapng, which includes a TFTP WRQ), and saw
   that the capitalization of the "Destination File" field is as expected in
   the packet dissection, and that the status bar now describes the field as
   the "TFTP destination file name".

Change-Id: I9f5bded321c16d4e200bf1caf80ad5733ecc8287
Reviewed-on: https://code.wireshark.org/review/30857
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Darius Davis 2018-12-01 17:59:00 +10:00 committed by Anders Broman
parent 71268f8bd1
commit b44172b4ee
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
epan/dissectors/packet-tftp.c
View File

@ -798,9 +798,9 @@ proto_register_tftp(void)
"TFTP source file name", HFILL }},
{ &hf_tftp_destination_file,
{ "DESTINATION File", "tftp.destination_file",
{ "Destination File", "tftp.destination_file",
FT_STRINGZ, BASE_NONE, NULL, 0x0,
"TFTP source file name", HFILL }},
"TFTP destination file name", HFILL }},
{ &hf_tftp_transfer_type,
{ "Type", "tftp.type",