osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Qt: traffic table: remove file_closed_ 

Remove the file_closed_ member from class TrafficTableDialog. We already
have a file_closed_ variable in the base class WiresharkDialog, which is
updated correctly when the file is closed.

The shadow file_closed_ variable in TrafficTableDialog is always false.
Classes that are derived from TrafficTableDialog will not see that the
capture file was closed.

The following scenario crashes Wireshark because of this bug

* open a capture file with TCP traffic
* Statistics / Conversations
* select a TCP conversation
* close the capture file
* press the Follow Stream button in the Conversations dialog
  -> Wireshark crashes

Change-Id: I8f3d55f231eae5ecc682ff90650f0005fea4b333
Reviewed-on: https://code.wireshark.org/review/33578
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Martin Kaiser 2019-06-12 15:30:08 -07:00 committed by Anders Broman
parent 3b9397dd8b
commit b147cbfc6c
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ui/qt/traffic_table_dialog.cpp
View File

@ -44,7 +44,6 @@ TrafficTableDialog::TrafficTableDialog(QWidget &parent, CaptureFile &cf, const c
WiresharkDialog(parent, cf),
ui(new Ui::TrafficTableDialog),
cap_file_(cf),
file_closed_(false),
filter_(filter),
nanosecond_timestamps_(false)
{

1
ui/qt/traffic_table_dialog.h
View File

@ -124,7 +124,6 @@ protected:
Ui::TrafficTableDialog *ui;
CaptureFile &cap_file_;
bool file_closed_;
QString filter_;
QMenu traffic_type_menu_;
QPushButton *copy_bt_;