osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

RTPS Removed the limit to the datatype number of elements 

The DataType must be parsed completely due to nested types. Putting a
limit on it might create issues when dissecting the user data samples.
This commit is contained in:
ismaelrti 2021-11-25 11:42:41 +01:00 committed by Alexis La Goutte
parent a3232592b0
commit b0a615075c
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
epan/dissectors/packet-rtps.c
View File

@ -5863,7 +5863,7 @@ static void rtps_util_add_type_element_struct(proto_tree *tree,
tvbuff_t * tvb, gint offset, const guint encoding, dissection_info * info) {
proto_tree * member;
guint32 member_id = 0, member_length = 0;
guint32 long_number, i, max_elements = 0;
guint32 long_number, i;
gint offset_tmp, member_size;
offset = rtps_util_add_type_library_type(tree, tvb, offset, encoding, info);
@ -5880,16 +5880,12 @@ static void rtps_util_add_type_element_struct(proto_tree *tree,
offset_tmp += 4;
max_elements = (enable_max_data_type_elements)
? MIN(long_number, rtps_max_data_type_elements)
: long_number;
if (info) {
info->elements = (dissection_element*)wmem_alloc0(
wmem_file_scope(),
sizeof(dissection_element) * max_elements);
sizeof(dissection_element) * long_number);
}
for (i = 0; i < max_elements; i++) {
for (i = 0; i < long_number; i++) {
member_size = offset_tmp;
member = proto_tree_add_subtree(tree, tvb, offset_tmp, 0,
ett_rtps_type_enum_constant, NULL, "");