osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Fix bytes view pane showing non-ASCII chars 

The bytes view pane in Qt is showing non-ASCII characters in the right-hand
side.  That's because the code is using isprint(), which is locale specific
and frequently includes non-ascii charscters such as the copyright symbol and
such. I wouldn't care, except some of those non-ASCII characters affects
the font height and makes it looks sloppy (the display output is set to a
fixed *width* font, but not fixed height font apparently).

Change-Id: Idd471c5fb769d3d67aa08bc507d168e686d48098
Reviewed-on: https://code.wireshark.org/review/548
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
This commit is contained in:
Hadriel Kaplan 2014-03-07 07:32:23 -05:00 committed by Alexis La Goutte
parent ee07cd9e24
commit a6809ce9aa
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/qt/byte_view_text.cpp
View File

@ -261,7 +261,7 @@ void ByteViewText::lineCommon(const int org_off)
EBCDIC_to_ASCII1(pd[off]) :
pd[off];
str += isprint(c) ? c : '.';
str += g_ascii_isprint(c) ? c : '.';
} else
str += ' ';