osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

From Stefan Puiu: 

A DHCP Discover option 90 has no Secret ID nor HMAC MD5 Hash.

svn path=/trunk/; revision=21636
This commit is contained in:
Jaap Keuter 2007-05-02 06:17:19 +00:00
parent 1cf1f16391
commit a25bb5b393
1 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
epan/dissectors/packet-bootp.c
View File

@ -1188,21 +1188,25 @@ bootp_option(tvbuff_t *tvb, proto_tree *bp_tree, int voff, int eoff,
switch (algorithm) {
case AUTHEN_DELAYED_ALGO_HMAC_MD5:
if (optlen < 31) {
proto_item_append_text(vti,
" length isn't >= 31");
if (!strcmp(*dhcp_type_p, val_to_str(1, opt53_text, ""))) {
/* Discover has no Secret ID nor HMAC MD5 Hash */
break;
} else {
if (optlen < 31) {
proto_item_append_text(vti,
" length isn't >= 31");
break;
}
proto_tree_add_text(v_tree, tvb, optoff, 4,
"Secret ID: 0x%08x",
tvb_get_ntohl(tvb, optoff));
optoff += 4;
optleft -= 4;
proto_tree_add_text(v_tree, tvb, optoff, 16,
"HMAC MD5 Hash: %s",
tvb_bytes_to_str(tvb, optoff, 16));
break;
}
proto_tree_add_text(v_tree, tvb, optoff, 4,
"Secret ID: 0x%08x",
tvb_get_ntohl(tvb, optoff));
optoff += 4;
optleft -= 4;
proto_tree_add_text(v_tree, tvb, optoff, 16,
"HMAC MD5 Hash: %s",
tvb_bytes_to_str(tvb, optoff, 16));
break;
default:
if (optleft == 0)
break;