From 9e3671562c23925f57c699ac303437713a3b4fef Mon Sep 17 00:00:00 2001 From: Zhenhua Hu Date: Mon, 29 Jun 2020 16:37:34 +0800 Subject: [PATCH] SMB: fix Response of SMB_COM_LOCKING_ANDX (0x24) Pass Length=0 to proto_tree_add_item will cause get_uint_value to throw error of 'Trying to fetch an unsigned integer with length 0'. Change-Id: I0fb457d175b719517419291adaedef5cacc9544a Reviewed-on: https://code.wireshark.org/review/37614 Reviewed-by: Zhenhua Hu Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman --- epan/dissectors/packet-smb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/epan/dissectors/packet-smb.c b/epan/dissectors/packet-smb.c index 9c397697ad..18e67700f9 100644 --- a/epan/dissectors/packet-smb.c +++ b/epan/dissectors/packet-smb.c @@ -6522,7 +6522,7 @@ dissect_locking_andx_response(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tre proto_tree *ltr; smb_lock_info_t *li; if (tree) { - litem = proto_tree_add_item(tree, hf_smb_lock_type, tvb, 0, 0, ENC_NA); + litem = proto_tree_add_uint(tree, hf_smb_lock_type, tvb, 0, 0, ld->type); proto_item_set_generated(litem); ltree = proto_item_add_subtree(litem, ett_smb_lock_type);