osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

SMB: fix Response of SMB_COM_LOCKING_ANDX (0x24) 

Pass Length=0 to proto_tree_add_item will cause get_uint_value
to throw error of 'Trying to fetch an unsigned integer with length 0'.

Change-Id: I0fb457d175b719517419291adaedef5cacc9544a
Reviewed-on: https://code.wireshark.org/review/37614
Reviewed-by: Zhenhua Hu <fattiger1102@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Zhenhua Hu 2020-06-29 16:37:34 +08:00 committed by Anders Broman
parent 360ae8b1c0
commit 9e3671562c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-smb.c
View File

@ -6522,7 +6522,7 @@ dissect_locking_andx_response(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tre
proto_tree *ltr;
smb_lock_info_t *li;
if (tree) {
litem = proto_tree_add_item(tree, hf_smb_lock_type, tvb, 0, 0, ENC_NA);
litem = proto_tree_add_uint(tree, hf_smb_lock_type, tvb, 0, 0, ld->type);
proto_item_set_generated(litem);
ltree = proto_item_add_subtree(litem, ett_smb_lock_type);