osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Don't do tvb_get...() in arg of g_htonl(); Macro evals args multiple times. 

svn path=/trunk/; revision=40440
This commit is contained in:
Bill Meier 2012-01-11 20:12:51 +00:00
parent e5f14929f1
commit 98fb51a3ed
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
epan/dissectors/packet-classicstun.c
View File

@ -513,8 +513,7 @@ dissect_classicstun(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
XOR (host order) transid with (host order) xor-address.
Add in network order tree. */
ti = proto_tree_add_ipv4(att_tree, classicstun_att_ipv4, tvb, offset+4, 4,
g_htonl(tvb_get_ntohl(tvb, offset+4) ^
transaction_id_first_word));
tvb_get_ipv4(tvb, offset+4) ^ g_htonl(transaction_id_first_word));
PROTO_ITEM_SET_GENERATED(ti);
break;