NDPS dissector is the poster child for proto_tree_add_subtree[_format].

Browse Source

NDPS dissector is also the poster child for not being considered "that naughty" by checkAPIs because most of its proto_tree_add_text calls don't have printf-style arguments (which is what checkAPIs really keys off of)

Fixed both cases and removed about 370 proto_tree_add_text calls from the dissector.

Change-Id: I721678c39d4a0544e5e7212e622c0c2eebfd04f7
Reviewed-on: https://code.wireshark.org/review/2775
Reviewed-by: Evan Huus <eapache@gmail.com>

...

This commit is contained in:

Michael Mann 2014-07-02 09:32:20 -04:00 committed by Evan Huus

parent a3bac6d0ce

commit 980893a15a

1 changed files with 558 additions and 831 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1389

epan/dissectors/packet-ndps.c

View File

File diff suppressed because it is too large Load Diff