osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

packet-rtp.c: Fix of variable names to test 

Variables are removed

Change-Id: I54bb00a74255625c7ce487cfd31794fcdb9fa979
Reviewed-on: https://code.wireshark.org/review/19295
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
This commit is contained in:
Jiri Novak 2016-12-15 23:15:51 +01:00 committed by Michael Mann
parent daf7c840fd
commit 93dec736c7
1 changed files with 31 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
epan/dissectors/packet-rtp.c
View File

@ -2251,20 +2251,18 @@ dissect_rtp( tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data _U_
/* Defined by profile field is 16 bits (2 octets) */ /* Defined by profile field is 16 bits (2 octets) */
hdr_extension_id = tvb_get_ntohs( tvb, offset ); hdr_extension_id = tvb_get_ntohs( tvb, offset );
if ( tree ) proto_tree_add_uint( rtp_tree, hf_rtp_prof_define, tvb, offset, 2, hdr_extension_id ); proto_tree_add_uint( rtp_tree, hf_rtp_prof_define, tvb, offset, 2, hdr_extension_id );
offset += 2; offset += 2;
hdr_extension_len = tvb_get_ntohs( tvb, offset ); hdr_extension_len = tvb_get_ntohs( tvb, offset );
if ( tree ) proto_tree_add_uint( rtp_tree, hf_rtp_length, tvb, offset, 2, hdr_extension_len); proto_tree_add_uint( rtp_tree, hf_rtp_length, tvb, offset, 2, hdr_extension_len);
offset += 2; offset += 2;
if ( hdr_extension_len > 0 ) { if ( hdr_extension_len > 0 ) {
proto_tree *rtp_hext_tree = NULL; proto_tree *rtp_hext_tree = NULL;
tvbuff_t *newtvb; tvbuff_t *newtvb;
if ( tree ) {
ti = proto_tree_add_item(rtp_tree, hf_rtp_hdr_exts, tvb, offset, hdr_extension_len * 4, ENC_NA); ti = proto_tree_add_item(rtp_tree, hf_rtp_hdr_exts, tvb, offset, hdr_extension_len * 4, ENC_NA);
rtp_hext_tree = proto_item_add_subtree( ti, ett_hdr_ext ); rtp_hext_tree = proto_item_add_subtree( ti, ett_hdr_ext );
}
/* pass interpretation of header extension to a registered subdissector */ /* pass interpretation of header extension to a registered subdissector */
newtvb = tvb_new_subset_length(tvb, offset, hdr_extension_len * 4); newtvb = tvb_new_subset_length(tvb, offset, hdr_extension_len * 4);
@ -2279,7 +2277,6 @@ dissect_rtp( tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data _U_
} }
else { else {
if ( !(dissector_try_uint(rtp_hdr_ext_dissector_table, hdr_extension_id, newtvb, pinfo, rtp_hext_tree)) ) { if ( !(dissector_try_uint(rtp_hdr_ext_dissector_table, hdr_extension_id, newtvb, pinfo, rtp_hext_tree)) ) {
if ( tree ) {
unsigned int hdrext_offset; unsigned int hdrext_offset;
hdrext_offset = offset; hdrext_offset = offset;
@ -2290,7 +2287,6 @@ dissect_rtp( tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data _U_
} }
} }
} }
}
offset += hdr_extension_len * 4; offset += hdr_extension_len * 4;
} }
@ -2383,7 +2379,7 @@ dissect_rtp( tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data _U_
* show all but the last byte as padding * show all but the last byte as padding
* data. * data.
*/ */
if ( tree ) proto_tree_add_item( rtp_tree, hf_rtp_padding_data, proto_tree_add_item( rtp_tree, hf_rtp_padding_data,
tvb, offset, padding_count - 1, ENC_NA ); tvb, offset, padding_count - 1, ENC_NA );
offset += padding_count - 1; offset += padding_count - 1;
} }
@ -2391,7 +2387,7 @@ dissect_rtp( tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data _U_
* Show the last byte in the PDU as the padding * Show the last byte in the PDU as the padding
* count. * count.
*/ */
if ( tree ) proto_tree_add_item( rtp_tree, hf_rtp_padding_count, proto_tree_add_item( rtp_tree, hf_rtp_padding_count,
tvb, offset, 1, ENC_BIG_ENDIAN ); tvb, offset, 1, ENC_BIG_ENDIAN );
} }
else { else {
@ -2457,8 +2453,10 @@ dissect_rtp_hdr_ext_ed137(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, v
proto_item *ti; proto_item *ti;
ti = proto_tree_add_item(tree, hf_rtp_hdr_ed137s, tvb, offset, hdr_extension_len * 4, ENC_NA); ti = proto_tree_add_item(tree, hf_rtp_hdr_ed137s, tvb, offset, hdr_extension_len * 4, ENC_NA);
rtp_hext_tree = proto_item_add_subtree( ti, ett_hdr_ext_ed137s ); rtp_hext_tree = proto_item_add_subtree( ti, ett_hdr_ext_ed137s );
}
for(i=0; i<hdr_extension_len; i++) { for(i=0; i<hdr_extension_len; i++) {
proto_item *ti2;
proto_tree *rtp_hext_tree2;
guint32 ext_value = tvb_get_ntohl( tvb, hdrext_offset ); guint32 ext_value = tvb_get_ntohl( tvb, hdrext_offset );
if (RTP_ED137_ptt_mask(ext_value)) { if (RTP_ED137_ptt_mask(ext_value)) {
@ -2467,9 +2465,6 @@ dissect_rtp_hdr_ext_ed137(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, v
if (RTP_ED137_squ_mask(ext_value)) { if (RTP_ED137_squ_mask(ext_value)) {
col_append_str(pinfo->cinfo, COL_INFO, ", SQU"); col_append_str(pinfo->cinfo, COL_INFO, ", SQU");
} }
if ( tree ) {
proto_item *ti2;
proto_tree *rtp_hext_tree2;
ti2 = proto_tree_add_item(rtp_hext_tree, hf_rtp_hdr_ed137, tvb, hdrext_offset, 4, ENC_NA); ti2 = proto_tree_add_item(rtp_hext_tree, hf_rtp_hdr_ed137, tvb, hdrext_offset, 4, ENC_NA);
rtp_hext_tree2 = proto_item_add_subtree( ti2, ett_hdr_ext_ed137 ); rtp_hext_tree2 = proto_item_add_subtree( ti2, ett_hdr_ext_ed137 );
@ -2523,10 +2518,10 @@ dissect_rtp_hdr_ext_ed137(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, v
} }
proto_tree_add_item( rtp_hext_tree2, hf_rtp_hdr_ed137_vf, tvb, hdrext_offset, 4, ENC_BIG_ENDIAN); proto_tree_add_item( rtp_hext_tree2, hf_rtp_hdr_ed137_vf, tvb, hdrext_offset, 4, ENC_BIG_ENDIAN);
}
hdrext_offset += 4; hdrext_offset += 4;
} }
} }
}
return tvb_captured_length(tvb); return tvb_captured_length(tvb);
} }
@ -2547,8 +2542,10 @@ dissect_rtp_hdr_ext_ed137a(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
proto_item *ti; proto_item *ti;
ti = proto_tree_add_item(tree, hf_rtp_hdr_ed137s, tvb, offset, hdr_extension_len * 4, ENC_NA); ti = proto_tree_add_item(tree, hf_rtp_hdr_ed137s, tvb, offset, hdr_extension_len * 4, ENC_NA);
rtp_hext_tree = proto_item_add_subtree( ti, ett_hdr_ext_ed137s ); rtp_hext_tree = proto_item_add_subtree( ti, ett_hdr_ext_ed137s );
}
for(i=0; i<hdr_extension_len; i++) { for(i=0; i<hdr_extension_len; i++) {
proto_item *ti2;
proto_tree *rtp_hext_tree2;
guint32 ext_value = tvb_get_ntohl( tvb, hdrext_offset ); guint32 ext_value = tvb_get_ntohl( tvb, hdrext_offset );
if (RTP_ED137A_ptt_mask(ext_value)) { if (RTP_ED137A_ptt_mask(ext_value)) {
@ -2557,9 +2554,6 @@ dissect_rtp_hdr_ext_ed137a(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
if (RTP_ED137A_squ_mask(ext_value)) { if (RTP_ED137A_squ_mask(ext_value)) {
col_append_str(pinfo->cinfo, COL_INFO, ", SQU"); col_append_str(pinfo->cinfo, COL_INFO, ", SQU");
} }
if ( tree ) {
proto_item *ti2;
proto_tree *rtp_hext_tree2;
ti2 = proto_tree_add_item(rtp_hext_tree, hf_rtp_hdr_ed137a, tvb, hdrext_offset, 4, ENC_NA); ti2 = proto_tree_add_item(rtp_hext_tree, hf_rtp_hdr_ed137a, tvb, hdrext_offset, 4, ENC_NA);
rtp_hext_tree2 = proto_item_add_subtree( ti2, ett_hdr_ext_ed137a ); rtp_hext_tree2 = proto_item_add_subtree( ti2, ett_hdr_ext_ed137a );
@ -2616,10 +2610,10 @@ dissect_rtp_hdr_ext_ed137a(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
/* Extended information is not used */ /* Extended information is not used */
proto_tree_add_item( rtp_hext_tree2, hf_rtp_hdr_ed137a_x_nu, tvb, hdrext_offset, 4, ENC_BIG_ENDIAN); proto_tree_add_item( rtp_hext_tree2, hf_rtp_hdr_ed137a_x_nu, tvb, hdrext_offset, 4, ENC_BIG_ENDIAN);
} }
}
hdrext_offset += 4; hdrext_offset += 4;
} }
} }
}
return tvb_captured_length(tvb); return tvb_captured_length(tvb);
} }