From 93d50f542f293450bb2fa0e922a151a4ac147a74 Mon Sep 17 00:00:00 2001 From: Darien Spencer Date: Mon, 6 Aug 2018 19:41:19 +0300 Subject: [PATCH] AT: Allow more CMEE command types Code was only allowing actions, while 'test', 'read' ,'action simply' and 'response' are also possible Change-Id: Iee84dd77912debe96a06f0b7d6b3e1f15527ce3b Reviewed-on: https://code.wireshark.org/review/28997 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu --- epan/dissectors/packet-at.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/epan/dissectors/packet-at.c b/epan/dissectors/packet-at.c index dfa6ae9e28..5617cc41e7 100644 --- a/epan/dissectors/packet-at.c +++ b/epan/dissectors/packet-at.c @@ -446,7 +446,9 @@ static gboolean check_cops(gint role, guint16 type) { } static gboolean check_cmee(gint role, guint16 type) { - if (role == ROLE_DTE && type == TYPE_ACTION) return TRUE; + if (role == ROLE_DTE && (type == TYPE_ACTION || type == TYPE_ACTION_SIMPLY || + type == TYPE_TEST || type == TYPE_READ)) return TRUE; + if (role == ROLE_DCE && type == TYPE_RESPONSE) return TRUE; return FALSE; } @@ -754,7 +756,8 @@ dissect_cmee_parameter(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree, { guint32 value; - if (!(role == ROLE_DTE && type == TYPE_ACTION)) { + if (!(role == ROLE_DTE && type == TYPE_ACTION) && + !(role == ROLE_DCE && type == TYPE_RESPONSE)) { return FALSE; }