osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

AT: Allow more CMEE command types 

Code was only allowing actions, while 'test', 'read' ,'action simply' and 'response'
are also possible

Change-Id: Iee84dd77912debe96a06f0b7d6b3e1f15527ce3b
Reviewed-on: https://code.wireshark.org/review/28997
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
This commit is contained in:
Darien Spencer 2018-08-06 19:41:19 +03:00 committed by Peter Wu
parent 522b737b57
commit 93d50f542f
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
epan/dissectors/packet-at.c
View File

@ -446,7 +446,9 @@ static gboolean check_cops(gint role, guint16 type) {
}
static gboolean check_cmee(gint role, guint16 type) {
if (role == ROLE_DTE && type == TYPE_ACTION) return TRUE;
if (role == ROLE_DTE && (type == TYPE_ACTION || type == TYPE_ACTION_SIMPLY ||
type == TYPE_TEST || type == TYPE_READ)) return TRUE;
if (role == ROLE_DCE && type == TYPE_RESPONSE) return TRUE;
return FALSE;
}
@ -754,7 +756,8 @@ dissect_cmee_parameter(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree,
{
guint32 value;
if (!(role == ROLE_DTE && type == TYPE_ACTION)) {
if (!(role == ROLE_DTE && type == TYPE_ACTION) &&
!(role == ROLE_DCE && type == TYPE_RESPONSE)) {
return FALSE;
}