osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Suggest pushing a decision lower in the code. 

That leaves less room for getting it wrong.

Change-Id: Iea003fc102ccd14db2924b70fc685033ca34f291
Reviewed-on: https://code.wireshark.org/review/13863
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This commit is contained in:
Guy Harris 2016-02-09 17:59:34 -08:00
parent c487d44e5d
commit 8bb1e58cbc
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
epan/reassemble.c
View File

@ -1219,7 +1219,13 @@ fragment_add_common(reassembly_table *table, tvbuff_t *tvb, const int offset,
gboolean already_added;
/* dissector shouldn't give us garbage tvb info */
/*
* Dissector shouldn't give us garbage tvb info.
*
* XXX - should this code take responsibility for preventing
* reassembly if data is missing due to the packets being
* sliced, rather than leaving it up to dissectors?
*/
DISSECTOR_ASSERT(tvb_bytes_exist(tvb, offset, frag_data_len));
fd_head = lookup_fd_head(table, pinfo, id, data, NULL);