osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

voip_calls_dialog/voip_calls: Fix for duplicated entries after retap 

Issue seen from 2.6:
1) Open pcap with any VoIP call
2) Open Telephony->VoIP calls
3) Select one or more calls
4) Press Flow Sequence - sequence is shown
5) Close Flow Sequence
6) Press Play Streams - Play dialog is shown
7) Close Play dialog
8) Press Flow Sequence - sequence is shown, but all entries are duplicated

If you repeat 6-7 multiple times, all entries are shown multiple times in 8

Patch adds missing clear of graph_analysis before retaping the stream.
Tested on master, but should be backported to as many stable branches as possible.

Change-Id: I9793f6e874defde2f377732d78689e957df71b33
Reviewed-on: https://code.wireshark.org/review/35672
Petri-Dish: Jim Young <jim.young.ws@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Jirka Novak 2020-01-06 23:59:29 +01:00 committed by Anders Broman
parent 2060e02021
commit 888137161c
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui/voip_calls.c
View File

@ -571,6 +571,10 @@ rtp_reset(void *tap_offset_ptr)
tapinfo->rtpstream_list = NULL;
tapinfo->nrtpstreams = 0;
if (tapinfo->graph_analysis) {
sequence_analysis_list_free(tapinfo->graph_analysis);
}
if (tapinfo->tap_reset) {
tapinfo->tap_reset(tapinfo);
}