osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Take a preemptive strike at some likely future VS Code Analyzer warnings about strings possibly not being zero-terminated. 

svn path=/trunk/; revision=54098
This commit is contained in:
Chris Maynard 2013-12-14 17:00:36 +00:00
parent 07a8d1b55a
commit 862b30c07a
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/profinet/packet-dcom-cba.c
View File

@ -561,17 +561,16 @@ dissect_ICBAPhysicalDevice_get_LogicalDevice_rqst(tvbuff_t *tvb, int offset,
guint32 u32MaxStr = sizeof(szStr);
gchar *call;
offset = dissect_dcom_this(tvb, offset, pinfo, tree, di, drep);
offset = dissect_dcom_dcerpc_pointer(tvb, offset, pinfo, tree, di, drep,
&u32Pointer);
szStr[0] ='\0';
if (u32Pointer) {
offset = dissect_dcom_BSTR(tvb, offset, pinfo, tree, di, drep,
hf_cba_name, szStr, u32MaxStr);
} else {
szStr[0] = '\0';
}
if (strlen(szStr) > 0) {
@ -756,6 +755,8 @@ dissect_ICBALogicalDevice_get_Name_resp(tvbuff_t *tvb, int offset,
if (u32Pointer) {
offset = dissect_dcom_BSTR(tvb, offset, pinfo, tree, di, drep,
hf_cba_name, szStr, u32MaxStr);
} else {
szStr[0] = '\0';
}
offset = dissect_dcom_HRESULT(tvb, offset, pinfo, tree, di, drep,
@ -845,6 +846,8 @@ dissect_ICBALogicalDevice_Get_RTAuto_rqst(tvbuff_t *tvb, int offset,
if (u32Pointer) {
offset = dissect_dcom_BSTR(tvb, offset, pinfo, tree, di, drep,
hf_cba_name, szStr, u32MaxStr);
} else {
szStr[0] = '\0';
}
col_append_fstr(pinfo->cinfo, COL_INFO, ": \"%s\"", szStr);
@ -873,6 +876,8 @@ dissect_ComponentInfo_resp(tvbuff_t *tvb, int offset,
if (u32Pointer) {
offset = dissect_dcom_BSTR(tvb, offset, pinfo, tree, di, drep,
hf_cba_component_id, szStr, u32MaxStr);
} else {
szStr[0] = '\0';
}
offset = dissect_dcom_dcerpc_pointer(tvb, offset, pinfo, tree, di, drep,
@ -880,6 +885,8 @@ dissect_ComponentInfo_resp(tvbuff_t *tvb, int offset,
if (u32Pointer) {
offset = dissect_dcom_BSTR(tvb, offset, pinfo, tree, di, drep,
hf_cba_component_version, szStr2, u32MaxStr2);
} else {
szStr2[0] = '\0';
}
offset = dissect_dcom_HRESULT(tvb, offset, pinfo, tree, di, drep, &u32HResult);