osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Remove a warning, add a comment guessing the intent 

Discovered investigating bug #9833, not the cause of that bug.

Change-Id: I53ee5c792eba8429d2c203c03e2f359a433ca262
Reviewed-on: https://code.wireshark.org/review/562
Reviewed-by: Evan Huus <eapache@gmail.com>
This commit is contained in:
Evan Huus 2014-03-08 14:34:44 -05:00
parent c2b762fd14
commit 80772d3a32
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
epan/dissectors/packet-jxta.c
View File

@ -1250,7 +1250,15 @@ static int dissect_jxta_message(tvbuff_t * tvb, packet_info * pinfo, proto_tree
if (0 == processed) {
/* XXX bondolo Not really clear what we should do! */
g_warning( "Failure processing message element #%d of %d of frame %d", each_elem, elem_count, pinfo->fd->num );
/* eapache: based on reading the code, I believe this can occur
* when the message_version is valid but the JXTA_MSGELEM_SIG
* (some sort of magic number?) is not. This almost
* certainly indicates a corrupt packet, so this should
* probably be expert info, not a g_warning. Pending confirmation
* just comment it out since a g_warning is definitely the
* wrong thing to do.
* g_warning( "Failure processing message element #%d of %d of frame %d", each_elem, elem_count, pinfo->fd->num );
*/
return 0;
}