osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Warn, in a comment, that an interface name could be a valid decimal number. 

Our current assumption that a numeric argument to -i must be an index
interface is not valid on Linux; see

	https://github.com/the-tcpdump-group/tcpdump/issues/522

Change-Id: Ieb6e17e6ceb23095a463336f0c88182373503aa6
Reviewed-on: https://code.wireshark.org/review/37369
Reviewed-by: Guy Harris <gharris@sonic.net>
This commit is contained in:
Guy Harris 2020-06-02 15:19:18 -07:00
parent 16ef9b6735
commit 7f9f781d32
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
capture_opts.c
View File

@ -660,9 +660,20 @@ capture_opts_add_iface_opt(capture_options *capture_opts, const char *optarg_str
* If the argument is a number, treat it as an index into the list
* of adapters, as printed by "tshark -D".
*
* This should be OK on UNIX systems, as interfaces shouldn't have
* This should be OK on UN*X systems, as interfaces shouldn't have
* names that begin with digits. It can be useful on Windows, where
* more than one interface can have the same name.
*
* XXX - "shouldn't have names that begin with digits" is not true
* on Linux; see
*
* https://github.com/the-tcpdump-group/tcpdump/issues/522
*
* tcpdump handles that by trying to open the device by name and,
* if that fails *and* the name is a syntactically valid number
* (optional sign, followed by decimal digits), reports an error
* if it's not a valid interface index, and otherwise uses it as
* an interface index.
*/
adapter_index = strtol(optarg_str_p, &p, 10);
if (p != NULL && *p == '\0') {