From 7f1d08585468facfc68c91d4f7e6783c7b5b60c3 Mon Sep 17 00:00:00 2001 From: Jaap Keuter Date: Mon, 18 Apr 2016 23:33:05 +0200 Subject: [PATCH] Use proper operator to find odd number (CID-1355647) Use binary AND instead of modulus operator to find odd number. Change-Id: I8eb819593ead66381cbe46997aab9d31955bad0c Reviewed-on: https://code.wireshark.org/review/14993 Reviewed-by: Michael Mann --- epan/dissectors/packet-smb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/epan/dissectors/packet-smb.c b/epan/dissectors/packet-smb.c index f804c9638f..d0d35ad3cf 100644 --- a/epan/dissectors/packet-smb.c +++ b/epan/dissectors/packet-smb.c @@ -8782,7 +8782,7 @@ dissect_nt_transaction_request(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tr offset += 2; /* this is a padding byte */ - if (offset%1) { + if (offset&1) { /* pad byte */ proto_tree_add_item(tree, hf_smb_padding, tvb, offset, 1, ENC_NA); offset += 1;