radiotap: Refactor some aspects of the radiotap dissector.

Browse Source

One thing I hate is big slabs of open coding. Compilers are very good these days
and will inline functions if they are used in only one place.

By using functions we make the code very much more readible.

There is also a big opportunity to use functions like proto_tree_add_bitmask.

Change-Id: I66d1509f577d2955996f4649e05494ab0370ed01
Reviewed-on: https://code.wireshark.org/review/24964
Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

...

This commit is contained in:

Richard Sharpe 2018-01-23 06:56:15 -08:00 committed by Anders Broman

parent fc6c5be229

commit 709757e996

1 changed files with 514 additions and 448 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

962

epan/dissectors/packet-ieee80211-radiotap.c

View File

File diff suppressed because it is too large Load Diff