osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Win32: Fix a string length check. 

Check the length of a string directly. Fixes Coverity CID 1487026.
This commit is contained in:
Gerald Combs 2021-07-07 10:28:40 -05:00 committed by Wireshark GitLab Utility
parent 73087d6fb4
commit 6dfa2cb0ae
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ui/win32/file_dlg_win32.cpp
View File

@ -887,7 +887,6 @@ filter_tb_get(HWND hwnd) {
static void
filter_tb_syntax_check(HWND hwnd, const TCHAR *filter_text) {
std::wstring strval;
gint len;
dfilter_t *dfp;
/* If filter_text is non-NULL, use it. Otherwise, grab the text from
@ -895,7 +894,7 @@ filter_tb_syntax_check(HWND hwnd, const TCHAR *filter_text) {
if (filter_text) {
strval = filter_text;
} else {
len = GetWindowTextLength(hwnd);
int len = GetWindowTextLength(hwnd);
if (len > 0) {
len++;
strval.resize(len);
@ -904,7 +903,7 @@ filter_tb_syntax_check(HWND hwnd, const TCHAR *filter_text) {
}
}
if (len == 0) {
if (strval.empty()) {
/* Default window background */
SendMessage(hwnd, EM_SETBKGNDCOLOR, (WPARAM) 1, COLOR_WINDOW);
return;