osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Note the lack of character-encoding indications in the protocol. 

Change-Id: Ie0306f9f9c0ef127bd61f702996029acaacbe220
Reviewed-on: https://code.wireshark.org/review/35545
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This commit is contained in:
Guy Harris 2019-12-21 23:14:58 -08:00
parent 8d65ccfee4
commit 6cd984011f
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
epan/dissectors/packet-whois.c
View File

@ -103,6 +103,14 @@ dissect_whois(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
"WHOIS: %s", is_query ? "Query" : "Answer");
whois_tree = proto_item_add_subtree(ti, ett_whois);
/*
* XXX - WHOIS, as RFC 3912 says, "has no mechanism for indicating
* the character set in use." We assume ASCII; if somebody wants
* to support non-ASCII WHOIS requets or responses, they should
* add a preference to specify the character encoding. These
* days, it'd probably be UTF-8, but there might be older servers
* using other character encodings.
*/
if (is_query) {
expert_ti = proto_tree_add_item(whois_tree, hf_whois_query, tvb, 0, -1, ENC_ASCII|ENC_NA);
if ((len < 2) || (tvb_memeql(tvb, len - 2, "\r\n", 2))) {