osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

opa-mad: use a simpler way to read a time field 

There's no need parse the time field ourselves. proto_tree_add_item()
supports the encoding that is used here.

Change-Id: Ifd8cb77f1225b84b9eaccfb0cc23c9c413c6e77b
Reviewed-on: https://code.wireshark.org/review/37901
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
This commit is contained in:
Martin Kaiser 2020-06-09 22:44:36 +02:00 committed by Alexis La Goutte
parent dc7f935330
commit 6b5e95c473
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
epan/dissectors/packet-opa-mad.c
View File

@ -7544,7 +7544,6 @@ static gint parse_GetImageInfo(proto_tree *parentTree, tvbuff_t *tvb, gint *offs
proto_item *GetImageInfo_header_item;
proto_tree *GetImageInfo_SM_tree;
guint32 numSMs;
nstime_t ts;
gint local_offset = *offset;
@ -7556,9 +7555,8 @@ static gint parse_GetImageInfo(proto_tree *parentTree, tvbuff_t *tvb, gint *offs
local_offset = parse_Image(GetImageInfo_header_tree, tvb, &local_offset);
ts.secs = (time_t)tvb_get_guint64(tvb, local_offset, ENC_BIG_ENDIAN);
ts.nsecs = 0;
proto_tree_add_time(GetImageInfo_header_tree, hf_opa_GetImageInfo_sweepStart, tvb, local_offset, 8, &ts);
proto_tree_add_item(GetImageInfo_header_tree, hf_opa_GetImageInfo_sweepStart,
tvb, local_offset, 8, ENC_TIME_SECS|ENC_BIG_ENDIAN);
local_offset += 8;
proto_tree_add_item(GetImageInfo_header_tree, hf_opa_GetImageInfo_sweepDuration, tvb, local_offset, 4, ENC_BIG_ENDIAN);
local_offset += 4;