osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity

Add a comment about wired-to-little-endian fields.

Browse source 
Other fields in the Prism header are in the same byte order as the magic
number; if the host generating those fields is big-endian, are these
fields little-endian or big-endian?

Change-Id: Ieb857db3ea63a673d9224cb2a7be3ff2bfb5861c
Reviewed-on: https://code.wireshark.org/review/20065
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This commit is contained in:
Guy Harris 2017-02-12 01:50:28 -08:00
parent e2c92fa99e
commit 6a3762576b
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
epan/dissectors/packet-ieee80211-prism.c
View file

@ -837,6 +837,10 @@ dissect_prism(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U
case PRISM_TYPE1_RATE_SIG_A1:
case PRISM_TYPE2_RATE_SIG_A1:
/*
* XXX - always little-endian, or same byte order as the
* rest of the Prism header?
*/
rate_phy1 = tvb_get_letohl(tvb, offset);
if (tree) {
proto_tree_add_item(prism_did_tree, hf_ieee80211_prism_did_sig_a1, tvb, offset, 4, byte_order);
@ -846,6 +850,10 @@ dissect_prism(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U
case PRISM_TYPE1_RATE_SIG_A2:
case PRISM_TYPE2_RATE_SIG_A2:
/*
* XXX - always little-endian, or same byte order as the
* rest of the Prism header?
*/
rate_phy2 = tvb_get_letohl(tvb, offset);
if (tree) {
proto_tree_add_item(prism_did_tree, hf_ieee80211_prism_did_sig_a2, tvb, offset, 4, byte_order);