osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Make sure first byte in ACAP packet is printable. 

Saves some false positives for protocols using port 674.

Bug: 12265
Change-Id: I7cb8aa9318639db0822b05b8c5b6f6563d8d4afc
Reviewed-on: https://code.wireshark.org/review/14521
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
This commit is contained in:
Michael Mann 2016-03-18 22:31:33 -04:00
parent a183726370
commit 68c84a7e66
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
epan/dissectors/packet-acap.c
View File

@ -90,6 +90,17 @@ dissect_acap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U_
int tokenlen;
const guchar *next_token;
/*
* If this should be a request or response, do this quick check to see if
* it begins with a string...
* Otherwise, looking for the end of line in a binary file can take a long time
* and this probably isn't ACAP
*/
if (!g_ascii_isprint(tvb_get_guint8(tvb, offset))) {
return 0;
}
col_set_str(pinfo->cinfo, COL_PROTOCOL, "ACAP");
/*