From 6891c21fe1e6830aaf9fb969b4d3564113f53b35 Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Mon, 9 Nov 2020 10:37:13 +0000 Subject: [PATCH] rlcmac: Fix EGPRS UL data block TLLI endianess According to TS 44.060, figure 10.3a.2.1, note 2, the TLLI is encoded in little endian for EGPRS (while big endian is used in GPRS). (cherry picked from commit dfa8a3fe5a1408a4355bb325d358dd1ab2c27d31) --- epan/dissectors/packet-gsm_rlcmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/epan/dissectors/packet-gsm_rlcmac.c b/epan/dissectors/packet-gsm_rlcmac.c index 397a98f6b6..f5d6eee43c 100644 --- a/epan/dissectors/packet-gsm_rlcmac.c +++ b/epan/dissectors/packet-gsm_rlcmac.c @@ -9660,7 +9660,7 @@ dissect_egprs_ul_data_block(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, /* the next fields are present according to earlier flags */ if (tlli_i) { - proto_tree_add_bits_item(data_tree, hf_tlli, tvb, offset * 8, 32, ENC_BIG_ENDIAN); + proto_tree_add_item(data_tree, hf_tlli, tvb, offset, 4, ENC_LITTLE_ENDIAN); offset += 4; } if (egprs_ul_header_info->pi)