osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

PIDL (DCERPC): fix Assigned value is garbage or undefined found by Clang Analyzer 

packet-dcerpc-dnsserver.c:1002:12: warning: Assigned value is garbage or undefined
packet-dcerpc-frstrans.c:1137:12: warning: Assigned value is garbage or undefined
packet-dcerpc-lsa.c:6345:12: warning: Assigned value is garbage or undefined
packet-dcerpc-nspi.c:7805:12: warning: Assigned value is garbage or undefined
packet-dcerpc-dfs.c:3245:11: warning: Function call argument is an uninitialized value
packet-dcerpc-dfs.c:3245:9: warning: 'level' may be used uninitialized in this function [-Wmaybe-uninitialized]

Change-Id: Ife6a2f565ae215535d0e3d72ef50800114240e3f
Reviewed-on: https://code.wireshark.org/review/4478
Reviewed-by: Evan Huus <eapache@gmail.com>
This commit is contained in:
Alexis La Goutte 2014-10-05 19:27:15 +02:00 committed by Evan Huus
parent de13887198
commit 683d657d49
7 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
epan/dissectors/packet-dcerpc-dfs.c
View File

@ -3258,7 +3258,7 @@ netdfs_dissect_element_dfs_EnumStruct_e(tvbuff_t *tvb _U_, int offset _U_, packe
int
netdfs_dissect_struct_dfs_EnumStruct(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *parent_tree _U_, dcerpc_info* di _U_, guint8 *drep _U_, int hf_index _U_, guint32 param _U_)
{
guint32 level;
guint32 level = 0;
proto_item *item = NULL;
proto_tree *tree = NULL;
int old_offset;

2
epan/dissectors/packet-dcerpc-dnsserver.c
View File

@ -1400,7 +1400,7 @@ dnsserver_dissect_element_DNS_RPC_RECORD_record(tvbuff_t *tvb _U_, int offset _U
int
dnsserver_dissect_struct_DNS_RPC_RECORD(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *parent_tree _U_, dcerpc_info* di _U_, guint8 *drep _U_, int hf_index _U_, guint32 param _U_)
{
guint16 Type;
guint16 Type = 0;
proto_item *item = NULL;
proto_tree *tree = NULL;
int old_offset;

2
epan/dissectors/packet-dcerpc-frstrans.c
View File

@ -1402,7 +1402,7 @@ frstrans_dissect_element_RdcParameters_u(tvbuff_t *tvb _U_, int offset _U_, pack
int
frstrans_dissect_struct_RdcParameters(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *parent_tree _U_, dcerpc_info* di _U_, guint8 *drep _U_, int hf_index _U_, guint32 param _U_)
{
guint1632 rdc_chunker_algorithm;
guint1632 rdc_chunker_algorithm = 0;
proto_item *item = NULL;
proto_tree *tree = NULL;
int old_offset;

2
epan/dissectors/packet-dcerpc-lsa.c
View File

@ -6394,7 +6394,7 @@ lsarpc_dissect_element_lsa_ForestTrustRecord_forest_trust_data(tvbuff_t *tvb _U_
int
lsarpc_dissect_struct_lsa_ForestTrustRecord(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *parent_tree _U_, dcerpc_info* di _U_, guint8 *drep _U_, int hf_index _U_, guint32 param _U_)
{
guint32 level;
guint32 level = 0;
proto_item *item = NULL;
proto_tree *tree = NULL;
int old_offset;

6
epan/dissectors/packet-dcerpc-nspi.c
View File

@ -1,6 +1,6 @@
/* DO NOT EDIT
This file was automatically generated by Pidl
from nspi/nspi.idl and nspi/nspi.cnf.
from nspi.idl and nspi.cnf.
Pidl is a perl based IDL compiler for DCE/RPC idl files.
It is maintained by the Samba team, not the Wireshark team.
@ -8029,7 +8029,7 @@ nspi_dissect_element_SRestriction_res(tvbuff_t *tvb _U_, int offset _U_, packet_
int
nspi_dissect_struct_SRestriction(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *parent_tree _U_, dcerpc_info* di _U_, guint8 *drep _U_, int hf_index _U_, guint32 param _U_)
{
guint32 rt;
guint32 rt = 0;
proto_item *item = NULL;
proto_tree *tree = NULL;
int old_offset;
@ -9284,7 +9284,7 @@ nspi_dissect_element_SPropValue_value(tvbuff_t *tvb _U_, int offset _U_, packet_
int
nspi_dissect_struct_SPropValue(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *parent_tree _U_, dcerpc_info* di _U_, guint8 *drep _U_, int hf_index _U_, guint32 param _U_)
{
guint32 ulPropTag;
guint32 ulPropTag = 0;
proto_item *item = NULL;
proto_tree *tree = NULL;
int old_offset;

2
epan/dissectors/packet-dcerpc-nspi.h
View File

@ -1,6 +1,6 @@
/* DO NOT EDIT
This file was automatically generated by Pidl
from nspi/nspi.idl and nspi/nspi.cnf.
from nspi.idl and nspi.cnf.
Pidl is a perl based IDL compiler for DCE/RPC idl files.
It is maintained by the Samba team, not the Wireshark team.

2
tools/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
View File

@ -641,7 +641,7 @@ sub Struct($$$$)
}
if ($switch_type ne "") {
push @$vars, "$switch_type $v;";
push @$vars, "$switch_type $v = 0;";
}
$switch_info = [ $_->{TYPE}, $v ];
$varswitchs->{$v} = $switch_info;