osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Add some more error checking. 

svn path=/trunk/; revision=37648
This commit is contained in:
Guy Harris 2011-06-10 17:16:09 +00:00
parent 59dc5adbc4
commit 6584ad9781
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
gtk/iax2_analysis.c
View File

@ -195,6 +195,7 @@ typedef enum {
TAP_RTP_PADDING_ERROR,
TAP_RTP_SHORT_FRAME,
TAP_RTP_FILE_OPEN_ERROR,
TAP_RTP_FILE_WRITE_ERROR,
TAP_RTP_NO_DATA
} error_type_t;
@ -686,7 +687,7 @@ static void iax2_packet_save_payload(tap_iax2_save_info_t *saveinfo,
const struct _iax2_info_t *iax2info)
{
const guint8 *data;
/* size_t nchars; */
size_t nchars;
/* is this the first packet we got in this direction? */
if (statinfo->flags & STAT_FLAG_FIRST) {
@ -712,11 +713,21 @@ static void iax2_packet_save_payload(tap_iax2_save_info_t *saveinfo,
if (iax2info->payload_len > 0) {
data = iax2info->payload_data;
/* nchars= */fwrite(data, sizeof(unsigned char), iax2info->payload_len, saveinfo->fp);
/* XXX: Should check for write error ? */
nchars = fwrite(data, sizeof(unsigned char), iax2info->payload_len, saveinfo->fp);
if (nchars != iax2info->payload_len) {
/* Write error or short write */
saveinfo->saved = FALSE;
saveinfo->error_type = TAP_RTP_FILE_WRITE_ERROR;
return;
}
saveinfo->count+=iax2info->payload_len;
fflush(saveinfo->fp);
if (fflush(saveinfo->fp) == EOF) {
/* Write error */
saveinfo->saved = FALSE;
saveinfo->error_type = TAP_RTP_FILE_WRITE_ERROR;
return;
}
saveinfo->saved = TRUE;
return;
}