osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

s7comm: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang 

Change-Id: Iddd57361c9e25e13a28fd86531f6195214a52848
Reviewed-on: https://code.wireshark.org/review/34199
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Thomas Wiens <th.wiens@gmx.de>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Alexis La Goutte 2019-08-06 13:04:29 +00:00 committed by Anders Broman
parent aa3598764e
commit 64ff87712f
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
epan/dissectors/packet-s7comm.c
View File

@ -4157,7 +4157,6 @@ s7comm_decode_ud_tis_param(tvbuff_t *tvb,
proto_tree_add_item(tp_tree, hf_s7comm_tis_register_db1_nr, tvb, offset, 2, ENC_BIG_ENDIAN);
offset += 2;
proto_tree_add_item(tp_tree, hf_s7comm_tis_register_db2_nr, tvb, offset, 2, ENC_BIG_ENDIAN);
offset += 2;
} else {
proto_tree_add_item(tp_tree, hf_s7comm_tis_p_callcond_blocktype, tvb, offset, 2, ENC_BIG_ENDIAN);
offset += 2;
@ -4165,7 +4164,6 @@ s7comm_decode_ud_tis_param(tvbuff_t *tvb,
offset += 2;
if (tp_size >= 38) {
proto_tree_add_item(tp_tree, hf_s7comm_tis_p_callcond_address, tvb, offset, 2, ENC_BIG_ENDIAN);
offset += 2;
}
}
}
@ -4173,7 +4171,6 @@ s7comm_decode_ud_tis_param(tvbuff_t *tvb,
proto_tree_add_item(tp_tree, hf_s7comm_tis_res_param1, tvb, offset, 2, ENC_NA);
offset += 2;
proto_tree_add_item(tp_tree, hf_s7comm_tis_res_param2, tvb, offset, 2, ENC_NA);
offset += 2;
}
}
/* May be we don't know all values when here, so set offset to the given length */
@ -4922,7 +4919,6 @@ s7comm_decode_ud_tis_bstack(tvbuff_t *tvb,
} else {
proto_tree_add_item(item_tree, hf_s7comm_tis_bstack_reserved, tvb, offset, rem, ENC_NA);
offset += rem;
rem = 0;
break;
}
}