From 60efc1a1c02e4235b0274ea3185c47508435574d Mon Sep 17 00:00:00 2001 From: Gtker Date: Sat, 4 Jun 2022 12:03:12 +0200 Subject: [PATCH] woww: Change SMSG_AUTH_RESPONSE result field size from 4 to 1 I somehow mistook the size of this field for a u32 instead of a u8 earlier. vmangos clearly shows that it's a u8: https://github.com/vmangos/core/blob/cd896d43712ceafecdbd8f005846d7f676e55b4f/src/game/World.cpp#L322 and cmangos: https://github.com/cmangos/mangos-classic/blob/98a53ea30db095ea88442449e3515fd20c9314c5/src/game/Server/WorldSession.cpp#L947 --- epan/dissectors/packet-woww.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/epan/dissectors/packet-woww.c b/epan/dissectors/packet-woww.c index a4849a9c62..444a377d89 100644 --- a/epan/dissectors/packet-woww.c +++ b/epan/dissectors/packet-woww.c @@ -4681,7 +4681,7 @@ add_body_fields(guint32 opcode, break; case SMSG_AUTH_RESPONSE: - ptvcursor_add(ptv, hf_woww_result, 4, ENC_LITTLE_ENDIAN); + ptvcursor_add(ptv, hf_woww_result, 1, ENC_NA); // There might more fields depending on the value in login_result. // Not implemented currently because they aren't that important. break; @@ -5048,7 +5048,7 @@ proto_register_woww(void) }, { &hf_woww_result, { "Result", "woww.result", - FT_UINT32, BASE_HEX, VALS(account_result_strings), 0, + FT_UINT8, BASE_HEX, VALS(account_result_strings), 0, NULL, HFILL } }, { &hf_woww_amount_of_characters,