osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Remove potential for a bad toshiba trace file to overflow a fixed char[] 

buffer in sscanf call.

svn path=/trunk/; revision=1012
This commit is contained in:
Gilbert Ramirez 1999-11-11 19:19:17 +00:00
parent 6043b610ed
commit 56b9fc4861
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
wiretap/toshiba.c
View File

@ -1,6 +1,6 @@
/* toshiba.c
*
* $Id: toshiba.c,v 1.3 1999/11/11 06:29:59 gram Exp $
* $Id: toshiba.c,v 1.4 1999/11/11 19:19:17 gram Exp $
*
* Wiretap Library
* Copyright (c) 1998 by Gilbert Ramirez <gram@xiexie.org>
@ -271,8 +271,10 @@ parse_toshiba_rec_hdr(wtap *wth, FILE *fh, int *err)
return -1;
}
/* Find text in line after "[No." */
num_items_scanned = sscanf(line, "%d] %d:%d:%d.%d %s %s",
/* Find text in line after "[No.". Limit the length of the
* two strings since we have fixed buffers for channel[] and
* direction[] */
num_items_scanned = sscanf(line, "%d] %d:%d:%d.%d %9s %9s",
&pktnum, &hr, &min, &sec, &csec, channel, direction);
if (num_items_scanned != 7) {